CB-13143: Integrate and replace SplashScreens with Launch Storyboard

[dpogue]

Platforms affected

iOS

Motivation and Context

1. Apple is deprecating Launch Images and will require Launch Storyboards for all apps as of April 2020 (Closes Use storyboards & default split screens support - required from July 2020 #770).

2. As per the decisions resulting from the plugin audit, CB-13143 intends to integrate the SplashScreen plugin API into each native platform and deprecate the plugin.

Description

• Remove the default Launch Images
• Remove support for Launch Images from the prepare step
• Integrate the required functionality for showing/hiding a screenshot of the Launch Storyboard to CDVViewController
• Add a built-in plugin with the same API as the SplashScreen plugin

Testing

• Manually created a test app and verified the launch storyboard behaviour.
• Manually confirmed the SplashScreen API works as intended from the JS side.

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[erisu]

@dpogue I pushed an update to remove the unit tests that I forgot to remove in the commit that you cherry picked. refactor (prepare): delete legacy splash screen launch images. The Jasmine unit tests should be OK now.

Locally I saw another error but from the Objective-C tests.

[dpogue]

@erisu FYI I rebased and squashed your Jasmine test fix commit into the one where the prepare code was removed.

This should hopefully pass all the Obj-C tests too

[codecov-io]

Codecov Report

Merging #790 into master will increase coverage by 0.43%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
+ Coverage    74.2%   74.63%   +0.43%     
==========================================
  Files          13       13              
  Lines        1849     1770      -79     
==========================================
- Hits         1372     1321      -51     
+ Misses        477      449      -28

Impacted Files	Coverage Δ
bin/templates/scripts/cordova/lib/prepare.js	85.71% <100%> (+3.65%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2922437...a1d5c03. Read the comment docs.

[erisu]

LGTM

[erisu]

During testing, this PR will also no longer provide or display the default Cordova splashscreen as designed. Same behaviour as Android platform to not show a default splashscreen.

[NiklasMerz]

Code LGTM 👍 . Simple test was successfull (if you read the instructions about the iOS simulator in the splashscreen repo :-)). The loading circle in the splashscreen is gone, too.

Does documentation need to move to this repo as well?

[erisu]

Documentation would need to go into cordova-doc.

Only the plugin documentation were written within its own repos and then the cordova-doc repo would grab it. Platform docs were manually managed directly in cordova-doc.

[codecov-commenter]

Codecov Report

Merging #790 into master will increase coverage by 0.44%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
+ Coverage   74.40%   74.85%   +0.44%     
==========================================
  Files          13       13              
  Lines        1821     1742      -79     
==========================================
- Hits         1355     1304      -51     
+ Misses        466      438      -28     

Impacted Files	Coverage Δ
bin/templates/scripts/cordova/lib/prepare.js	85.71% <100.00%> (+3.65%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43e3bbd...23cfa1a. Read the comment docs.

[kanongil]

This displays an empty screen for me (transparent, unless backgroundcolor is set). The storyboard is loaded and ok, but the view returned from snapshotViewAfterScreenUpdates: is blank.

[kanongil]

This method delays showing the splash screen by SplashScreenDelay ms when visible = YES.

[erisu]

@kanongil Please test against nightly or master.

The Issue you are mentioning sound relatively similar to what has already been reported and fixed in master.

• Problem with splashscreen and cordova-ios 6.0.0 #890
• Set the background colour as an xcasset color set #896

If you have any issues please open a new ticket instead of messaging inside a PR which has already been merged and released.