feature: add CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED#803
Merged
erisu merged 1 commit intoapache:masterfrom Feb 29, 2020
Merged
feature: add CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED#803erisu merged 1 commit intoapache:masterfrom
erisu merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #803 +/- ##
======================================
Coverage 74.2% 74.2%
======================================
Files 13 13
Lines 1849 1849
======================================
Hits 1372 1372
Misses 477 477Continue to review full report at Codecov.
|
dpogue
approved these changes
Feb 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Apply Xcode Recommendation to enable the static analyzer to check for missing localizability.
Description
Added
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZEDflag.This flag will only warn when a non-localized string is passed to a user-interface method. It will help people understand why something might not display in the correct localization.
Testing
npm tChecklist