breaking: replace shelljs with fs-extra#851
Merged
erisu merged 19 commits intoapache:masterfrom May 27, 2020
Merged
Conversation
a55f605 to
0d98b03
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #851 +/- ##
==========================================
- Coverage 74.85% 74.76% -0.09%
==========================================
Files 13 13
Lines 1742 1736 -6
==========================================
- Hits 1304 1298 -6
Misses 438 438 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced May 20, 2020
breautek
reviewed
May 22, 2020
* Replace pgrep command with find-process * Replace shell.exec with superspawn.spawn
* Added missing defaults.xml test fixture file
0447780 to
b9b99fa
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation, Context & Description
shelljsdependency forfs-extra.Testing
npm tChecklist