Skip to content

breaking: replace shelljs with fs-extra#851

Merged
erisu merged 19 commits intoapache:masterfrom
erisu:breaking/replace-shelljs-with-fs-extra
May 27, 2020
Merged

breaking: replace shelljs with fs-extra#851
erisu merged 19 commits intoapache:masterfrom
erisu:breaking/replace-shelljs-with-fs-extra

Conversation

@erisu
Copy link
Copy Markdown
Member

@erisu erisu commented May 16, 2020

Motivation, Context & Description

  • Remove shelljs dependency for fs-extra.

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 6.0.0 milestone May 16, 2020
@erisu erisu requested review from NiklasMerz, dpogue and timbru31 May 16, 2020 14:07
@erisu erisu force-pushed the breaking/replace-shelljs-with-fs-extra branch from a55f605 to 0d98b03 Compare May 20, 2020 02:08
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 20, 2020

Codecov Report

❌ Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.76%. Comparing base (67bea75) to head (b9b99fa).
⚠️ Report is 291 commits behind head on master.

Files with missing lines Patch % Lines
bin/templates/scripts/cordova/lib/build.js 50.00% 2 Missing ⚠️
bin/templates/scripts/cordova/lib/run.js 0.00% 2 Missing ⚠️
...ates/scripts/cordova/lib/plugman/pluginHandlers.js 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #851      +/-   ##
==========================================
- Coverage   74.85%   74.76%   -0.09%     
==========================================
  Files          13       13              
  Lines        1742     1736       -6     
==========================================
- Hits         1304     1298       -6     
  Misses        438      438              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This was referenced May 20, 2020
@erisu erisu force-pushed the breaking/replace-shelljs-with-fs-extra branch from 0447780 to b9b99fa Compare May 22, 2020 11:27
@erisu erisu requested a review from breautek May 22, 2020 14:02
Copy link
Copy Markdown
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu merged commit 8dce55f into apache:master May 27, 2020
@erisu erisu deleted the breaking/replace-shelljs-with-fs-extra branch May 27, 2020 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants