Conversation
Codecov Report
@@ Coverage Diff @@
## master #886 +/- ##
==========================================
+ Coverage 74.40% 76.30% +1.89%
==========================================
Files 13 13
Lines 1676 1941 +265
==========================================
+ Hits 1247 1481 +234
- Misses 429 460 +31
Continue to review full report at Codecov.
|
timbru31
approved these changes
Jun 5, 2020
erisu
reviewed
Jun 12, 2020
CordovaLib/Classes/Private/Plugins/CDVWebViewEngine/CDVWebViewEngine.m
Outdated
Show resolved
Hide resolved
erisu
reviewed
Jun 12, 2020
CordovaLib/Classes/Private/Plugins/CDVWebViewEngine/CDVWebViewEngine.m
Outdated
Show resolved
Hide resolved
Co-authored-by: エリス <erisu@users.noreply.github.com>
jcesarmobile
approved these changes
Jun 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
This adds a prefrence to the webview which is useful for iPads. Apple introduced a setting which by defaults changes the useragent of iPads from
iPadtoMacintoshto provide a "desktop browsing experience". The new preference allows to change the default value.See original issue from IAB: apache/cordova-plugin-inappbrowser#687
Description
Changed like : apache/cordova-plugin-inappbrowser#688
Documenation: apache/cordova-docs#1083
Testing
Automatic tests still pass. I found no automatic tests for preferences at build time.
I created a blank new app, added this platform and checked
navigator.userAgentwhile changing the preference. It should beiPadformobileandMacintoshfordesktop.Checklist
(platform)if this change only applies to one platform (e.g.(android))