Skip to content

ANSI SQL String concatenation operator || #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
christos-h opened this issue Apr 16, 2020 · 3 comments
Closed

ANSI SQL String concatenation operator || #160

christos-h opened this issue Apr 16, 2020 · 3 comments
Labels
good first issue Good for newcomers

Comments

@christos-h
Copy link

Hi.

Great crate thank you very much for your work.

I think there isn't support for ANSI SQL String concatenation:

SELECT "a" || "b" FROM ...

Is there plan to support this soon?

I think most SQL dialects support the CONCAT function, but I don't think it's ANSI SQL.
@nickolay nickolay changed the title ANSI SQL String concatenation ANSI SQL String concatenation operator || Apr 21, 2020
@nickolay
Copy link
Contributor

Hi! You're right that || is the standard way to concatenate strings (per 6.31 <string value expression>), unlike CONCAT. I don't know of anyone working to implement it, so if you were thinking to make a pull request, it would be most welcome!

@christos-h
Copy link
Author

Maybe label it as 'help wanted'.

If I find some time I'll give it a shot.

@nickolay nickolay added the good first issue Good for newcomers label Apr 21, 2020
@Dandandan Dandandan mentioned this issue Jun 1, 2020
Merged
@nickolay
Copy link
Contributor

nickolay commented Jun 2, 2020

Fixed in #178.

@nickolay nickolay closed this as completed Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nickolay @christos-h