-
Notifications
You must be signed in to change notification settings - Fork 601
Support the string concat operator #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Support the string concat operator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, apart from the typo noted in a separate comment.
Thanks!
src/tokenizer.rs
Outdated
// a regular '/' operator | ||
_ => Err(TokenizerError(format!( | ||
"Tokenizer Error at Line: {}, Col: {}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reference to '/' is presumably a typo. This should probably say we don't support the single-pipe |
token (bitwise OR in some dialects, but not part of the standard)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some modifications to the error message.
Probably, it would be useful though to support |
too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, another improvement would be to include a simple function which adds line/column information in a consistent way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, it would be useful though to support
|
too.
Yes, I see no reason not to.
include a simple function which adds line/column information in a consistent way.
Agreed. I see you filed #179 about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes :)
Thanks! |
Adds support for string concatenation operator
||
https://github.com/andygrove/sqlparser-rs/issues/160