Add support for "on delete cascade" column option #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickolay
suggested changes
May 26, 2020
There was a problem hiding this comment.
Thanks for this! I'd prefer to split c67d667 into a separate PR, so that this PR could be merged independently, and the discussion about evolving our dialect support would be more visible.
As for ON { UPDATE | DELETE } { RESTRICT | CASCADE | SET NULL | NO ACTION | SET DEFAULT }, please see my comments inline...
(Note: ANSI SQL calls a <referential triggered action>, and here are the Postgres docs.)
c7hm4r
force-pushed
the
on_delete_option
branch
3 times, most recently
from
2fbdaea to
79514b7
Compare
|
I reworked the PR. I will create a new PR for the new dialect option. |
nickolay
suggested changes
May 26, 2020
nickolay
added a commit
that referenced
this pull request
Aug 10, 2020
* Change `Parser { ... }` to store the dialect used:
`Parser<'a> { ... dialect: &'a dyn Dialect }`
Thanks to @c7hm4r for the initial version of this submitted as
part of #170
* Introduce `dialect_of!(parser is SQLiteDialect | GenericDialect)` helper
to branch on the dialect's type
* Use the new functionality to make `AUTO_INCREMENT` and `AUTOINCREMENT`
parsing dialect-dependent.
Co-authored-by: Christoph Müller <[email protected]>
Co-authored-by: Nickolay Ponomarev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces some breaking changes.
Is it a good idea to have a lifetime parameter in
Parser?