Skip to content

Add line and column number to TokenizerError, add helper function #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2020
Merged

Add line and column number to TokenizerError, add helper function #194

merged 3 commits into from
Jun 10, 2020

Conversation

Dandandan
Copy link
Contributor

@Dandandan Dandandan commented Jun 9, 2020 •
edited
Loading

@coveralls
Copy link

coveralls commented Jun 9, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 130065195

  • 12 of 18 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 91.667%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 0 3 0.0%
src/tokenizer.rs 12 15 80.0%
Totals Coverage Status
Change from base Build 127811132: 0.05%
Covered Lines: 4048
Relevant Lines: 4416
💛 - Coveralls

@Dandandan Dandandan changed the title Change pattern of tokenize errors to always include column and line number in error Add line and column number to TokenizerError, add helper function Jun 9, 2020
@nickolay nickolay merged commit d842f49 into apache:master Jun 10, 2020
@nickolay
Copy link
Contributor

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dandandan @coveralls @nickolay