-
Notifications
You must be signed in to change notification settings - Fork 603
Add code example to see how to use serde #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 132333060
💛 - Coveralls |
My suggestion was to include it as an option to an existing example, like this: So that we could recommend something like What do you mean by bothersome? |
I think now I got the point. I meant bothersome, it just comes from misunderstanding of the purpose of And I also didn't know if cfg!(not(feature = "cst")) { ... }
#[cfg(feature = "cst")]
{
//...
} Those kind of patterns, that's really cool. Thanks to let me know! Ok, then it makes sense to apply I'll update |
I forgot that doing that would build serde unconditionally in dev mode (as cargo doesn't allow optional dev-dependencies). I try to minimize the amount of stuff we build by default to keep the build times down. Which means we'd have to move the Or move serde_json to |
Wow, that both two options sound very reasonable, it's quite tough to pick only one. Ok, than how about taking your adding If By the way, https://github.com/andygrove/sqlparser-rs/pull/190 was also so good idea to take, thanks for sharing, it was so fun to see what was going on there. |
This makes sense. So I merged the single-crate variant for now. Thanks for your help! |
andygrove@a0f076a#diff-6d3ae06537fccb04d134faab9e782c45R67-R70 if cfg!(feature = "json_example") {
#[cfg(feature = "json_example")]
{
...
}
... by the way, cool, this looks better than put |
Related to PR: https://github.com/andygrove/sqlparser-rs/pull/196
Because
serde
is an optional dependency, if I modify existing example codes, then it may make other new comers feel bothersome.So I added new code example named
examples/serde.rs
.@nickolay How do you think of this?