Skip to content

Take slice as input for parse_keywords #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Conversation

Dandandan
Copy link
Contributor

Just a purely mechanical change to change parse_keywords take a slice instead of a Vec.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 132630018

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.708%

Totals Coverage Status
Change from base Build 132625322: 0.0%
Covered Lines: 4070
Relevant Lines: 4438

💛 - Coveralls

@nickolay nickolay merged commit f4fbd9b into apache:master Jun 11, 2020
@nickolay
Copy link
Contributor

Nice! I think the point is that a slice is a static constant whereas vec![..] builds the value dynamically?

@Dandandan
Copy link
Contributor Author

Dandandan commented Jun 12, 2020

Yes, that's the point. This is a bit more "rusty".

You can also pass a vec to this function, but not a slice to a function expecting a vec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants