-
Notifications
You must be signed in to change notification settings - Fork 602
Fix performance of very nested SQL files, add example to benchmark #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 152428199
💛 - Coveralls |
I included a fix which memoizes the unsuccesful usage of This brings down the benchmark to 109.24 microseconds (687 times speedup for this extreme example). |
@Dandandan Is this PR still something we should work on to help contribute? |
I think the benchmark is a useful example of some problematic input for the parser. |
Closing old PRs. Please feel free to re-open if this was a mistake |
This adds one of the inputs found during fuzzing as benchmarking input.
#216
According to benchmark,the query takes 75.814 ms on average. That is much more than the other benchmarks, which are more than 1000x as fast (3 / 17 microseconds).
I included a fix which memoizes the unsuccesful usage of parse_derived_table_factor.
This brings down the benchmark to 109.24 microseconds (687 times speedup for this extreme example).