perf: optimize make_word() to avoid unnecessary allocations#2176
Merged
iffyio merged 1 commit intoapache:mainfrom Jan 24, 2026
Merged
perf: optimize make_word() to avoid unnecessary allocations#2176iffyio merged 1 commit intoapache:mainfrom
make_word() to avoid unnecessary allocations#2176iffyio merged 1 commit intoapache:mainfrom
Conversation
- Skip uppercase allocation entirely for quoted identifiers since they are never keywords - Use to_ascii_uppercase() instead of to_uppercase() since SQL keywords are ASCII-only, avoiding Unicode case conversion overhead This is a hot path called for every identifier/keyword token in queries. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Feb 3, 2026
…#2176) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
fmguerreiro
pushed a commit
to fmguerreiro/datafusion-sqlparser-rs
that referenced
this pull request
Feb 20, 2026
…#2176) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimizes the
Token::make_word()function which is called for every identifier and keyword token during tokenization.Changes:
"myColumn",`table`) since they are never keywordsto_ascii_uppercase()instead ofto_uppercase()since SQL keywords are ASCII-only, avoiding Unicode case conversion overheadBefore:
After:
Test plan
cargo clippypasses🤖 Generated with Claude Code