minor: reduce unnecessary string allocations#2178
Merged
iffyio merged 1 commit intoapache:mainfrom Jan 23, 2026
Merged
Conversation
049fb83 to
45bf510
Compare
- Replace `String::from("?") + &s` with `format!("?{s}")` in tokenizer
- Replace `String::from("$") + &value` with `format!("${value}")` in tokenizer
- Replace `tok.to_string() + &ident.value` with `format!("{tok}{}", ident.value)` in parser
- Replace `" ".to_string() + &...` with `format!(" {}", ...)` in AST display
- Replace `String::from("")` with `String::new()`
- Replace `.to_string()` + `.clear()` with `std::mem::take()` to avoid cloning
The format!() macro calculates required capacity upfront and allocates once,
avoiding potential reallocation. std::mem::take() moves the String instead
of cloning it.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
45bf510 to
b837a63
Compare
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Feb 3, 2026
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
fmguerreiro
pushed a commit
to fmguerreiro/datafusion-sqlparser-rs
that referenced
this pull request
Feb 20, 2026
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace string concatenation patterns with more efficient alternatives.
Changes:
Tokenizer - Replace
String::from() + &strwithformat!():Parser - Replace placeholder value concatenation:
AST Display - Replace string concatenation in FLUSH statement:
Parser COPY TSV - Avoid unnecessary clone:
The
format!()macro calculates required capacity upfront and allocates once.std::mem::take()moves the String instead of cloning it.Test plan
cargo clippypasses🤖 Generated with Claude Code