Snowflake dialect #259
Merged
Snowflake dialect #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a pull request for snowflake dialect . |
Pull Request Test Coverage Report for Build 204251590
💛 - Coveralls |
Dandandan
reviewed
Aug 10, 2020
nickolay
suggested changes
Aug 10, 2020
There was a problem hiding this comment.
Note to self: this is the result of splitting #244 into separate PRs at my request. We needed a new dialect to make the parsing quirk dealing with FROM ((table_name)) alias Snowflake-specific.
Please don't forget to add the new dialect to cli.rs and to all_dialects(): https://github.com/ballista-compute/sqlparser-rs/search?q=MsSqlDialect&unscoped_q=MsSqlDialect
tests/sqlparser_snowflake.rs
Outdated
|
|
||
| fn snowflake_and_generic() -> TestedDialects { | ||
| TestedDialects { | ||
| // we don't have a separate SQLite dialect, so test only the generic dialect for now |
There was a problem hiding this comment.
This comment doesn't belong here.
eyalleshem
force-pushed
the
snowflake_dialect
branch
2 times, most recently
from
9055ebf to
f16b90a
Compare
nickolay
suggested changes
Aug 11, 2020
eyalleshem
force-pushed
the
snowflake_dialect
branch
from
f16b90a to
db4bad0
Compare
|
Sorry , missed that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.