-
Notifications
You must be signed in to change notification settings - Fork 605
Support for joins #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 78
💛 - Coveralls |
ad1e9a6
to
9e14674
Compare
9e14674
to
7202466
Compare
Thanks @fredrikroos I will review this over the weekend. It does look like there are some merge conflicts now. Sorry for the delay in reviewing. |
Patch by Fredrik Roos <https://github.com/andygrove/sqlparser-rs/pull/28>
I rebased this on top of the current master, but can't share it in this PR, so here's a link to a commit in my fork: nickolay@9e9da81 This is roughly how I "rebased": $ git reset --hard face972 # this PR's base |
@fredrikroos I fixed the merge conflict using the web editor. There is now one failing test - could you take a look please? |
Thanks @fredrikroos I merged this manually and fixed the failing test |
Supports inner join, left/right/full outer join, cross join and implicit join. Join constraint can be ON expression, USING expression or NATURAL.
There is some formatting noise in this commit that can be dealt with by a cargo-fmt commit in master and then rebasing this PR.