add support for postgres composite types #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: password <[email protected]>
Signed-off-by: password <[email protected]>
Pull Request Test Coverage Report for Build 2196255464
💛 - Coveralls |
alamb
approved these changes
May 9, 2022
| @@ -516,7 +516,18 @@ impl<'a> Parser<'a> { | |||
| } | |||
| }; | |||
| self.expect_token(&Token::RParen)?; | |||
| Ok(expr) | |||
| if !self.consume_token(&Token::Period) { | |||
There was a problem hiding this comment.
I am thinking if the CompositeAccess can only appear after a ) -- it seems like it should be possible in other places, though i suppose without a parenthesis .<name> will appear as a compound identifier.
alamb
added a commit
to alamb/sqlparser-rs
that referenced
this pull request
May 9, 2022
alamb
added a commit
that referenced
this pull request
May 10, 2022
* Update changelog for 0.17.0 * add reference to #466 * Updates for recent merges
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for postgres composite values.
ref: https://www.postgresql.org/docs/current/rowtypes.html#:~:text=A%20composite%20type%20represents%20the,be%20of%20a%20composite%20type
Signed-off-by: password [email protected]