Skip to content

Support unicode whitespace #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2022
Merged

Support unicode whitespace #482

merged 2 commits into from
May 15, 2022

Conversation

alexsatori
Copy link
Contributor

Allows parsing correctly the following:
SELECT * FROM orgdata.public. customers;
(Note that the space is U+2003)

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexsatori

Can you please include a test for this case so that it doesn't accidentally get broken in the future?

@alamb
Copy link
Contributor

alamb commented May 9, 2022

FYI I plan to release 0.17.0 tomorrow in case you want to work on this PR before then: #488

@coveralls
Copy link

coveralls commented May 9, 2022

Pull Request Test Coverage Report for Build 2314031376

  • 11 of 12 (91.67%) changed or added relevant lines in 1 file are covered.
  • 569 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.09%) to 90.485%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/tokenizer.rs 11 12 91.67%
Files with Coverage Reduction New Missed Lines %
src/dialect/mod.rs 1 92.86%
tests/sqlparser_postgres.rs 1 99.87%
src/test_utils.rs 2 83.08%
tests/sqlparser_common.rs 21 99.1%
src/tokenizer.rs 32 90.12%
src/ast/mod.rs 181 77.99%
src/parser.rs 331 82.98%
Totals Coverage Status
Change from base Build 2260629052: 0.09%
Covered Lines: 8302
Relevant Lines: 9175

💛 - Coveralls

@alexsatori
Copy link
Contributor Author

alexsatori commented May 12, 2022

@alamb sorry for the delay, was on vacation, test added.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @alexsatori

@alexsatori
Copy link
Contributor Author

How do I get this merged?

@alamb
Copy link
Contributor

alamb commented May 15, 2022

Thanks @alexsatori !

@alamb alamb merged commit dd805e9 into apache:main May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants