Skip to content

Add docs for MapAccess #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 22, 2022
Merged

Add docs for MapAccess #489

merged 5 commits into from
May 22, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented May 9, 2022

I found an undocumented variant when reviewing another PR.

This appears to have been introduced by @hntd187 in #235

expr: Box<Expr>,
key: Ident,
},
CompositeAccess { expr: Box<Expr>, key: Ident },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why cargo fmt made these formatting changes in this PR

@coveralls
Copy link

coveralls commented May 9, 2022

Pull Request Test Coverage Report for Build 2367454938

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.755%

Totals Coverage Status
Change from base Build 2367433069: 0.0%
Covered Lines: 8235
Relevant Lines: 9175

💛 - Coveralls

@alamb alamb merged commit 85e0e5f into apache:main May 22, 2022
@alamb alamb deleted the alamb/docs_for_map_access branch May 22, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants