refactor: replace OnceLock with LazyLock
#13641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
jonahgao
commented
Dec 4, 2024
| // TODO: Use LazyLock instead of getter function when MSRV gets bumped | ||
| static $name: OnceLock<LogicalTypeRef> = OnceLock::new(); | ||
| static $name: LazyLock<LogicalTypeRef> = | ||
| LazyLock::new(|| Arc::new(NativeType::$ty)); | ||
|
|
||
| #[doc = "Getter for singleton instance of a logical type representing"] | ||
| #[doc = concat!("[`NativeType::", stringify!($ty), "`].")] | ||
| pub fn $getter() -> LogicalTypeRef { |
There was a problem hiding this comment.
Current callers require a LogicalTypeRef, so this getter still seems to be needed.
alamb
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Thanks @jonahgao
THere appear to be quite a few more uses of OnceLock in th code too:
https://github.com/search?q=repo%3Aapache%2Fdatafusion+OnceLock&type=code
Do you plan on moving them too?
I also linked this PR to #11687 which has a few other PRs linked as well that were in draft
|
Thats good point, wondering we probably want to use LazyLock in documentation generation |
zhuliquan
pushed a commit
to zhuliquan/datafusion
that referenced
this pull request
Dec 6, 2024
* refactor: Replace OnceLock with LazyLock * Fix typo
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #11687
Clear the TODOs after updating MSRV to 1.80.
Rationale for this change
LazyLockhas been stable since Rust version 1.80.0, and it provides a simpler and more suitable way to define static variables.What changes are included in this PR?
Are these changes tested?
Yes. By existing tests.
Are there any user-facing changes?
No