Skip to content

Fix: New Datafusion-cli streaming printing way should handle corner case for only one small batch which lines are less than max_rows #14921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2010YOUY01 merged 3 commits into from
Feb 28, 2025
Merged

Fix: New Datafusion-cli streaming printing way should handle corner case for only one small batch which lines are less than max_rows #14921

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acf57c8
BUG: fix datafusion-cli missing case with only one batch and smaller …
zhuqi-lucas Feb 27, 2025
1d6b50f
Fix
zhuqi-lucas Feb 28, 2025
3ba5943
Add test case
zhuqi-lucas Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion datafusion-cli/src/print_options.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ impl PrintOptions {
print_options
.format
.print_header(&schema, &widths, writer)?;
header_printed = true;
}
for preview_batch in preview_batches.drain(..) {
print_options.format.print_batch_with_widths(
Expand Down Expand Up @@ -198,6 +197,13 @@ impl PrintOptions {
writer,
)?;
}
for preview_batch in preview_batches.drain(..) {
print_options.format.print_batch_with_widths(
&preview_batch,
precomputed_widths.as_ref().unwrap(),
writer,
)?;
}
}
if let Some(ref widths) = precomputed_widths {
print_options.format.print_bottom_border(widths, writer)?;
Expand Down