Skip to content

Minor: fix upgrade papercut pub use PruningStatistics #16264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 5, 2025

Which issue does this PR close?

Rationale for this change

While testing the DataFuion upgrade in delta.rs I found that PruningStatistics is no longer exported from datafusion::physical_optimizer::pruning after #16069

The fix downstream is easy (use the new import location) but I think leaving a backwards compatible pub use would mean no changes needed

What changes are included in this PR?

  1. change use to pub use so downstream users can upgrade without change

Are these changes tested?

By CI

Are there any user-facing changes?

@alamb
Copy link
Contributor Author

alamb commented Jun 5, 2025

Thank you @adriangb

@alamb
Copy link
Contributor Author

alamb commented Jun 5, 2025

Screenshot 2025-06-05 at 2 10 20 PM

🤔 your github account doesn't seem to be linked to your apache account yet so the checkmark is still grey

I thought I saw an email fly by that your apache account was made (by maybe not) 🤔

Then you need to do

Once you are notified that your Apache account has been created, you must then:

  1. Add your GitHub username to your account at id.apache.org

  2. Follow the instructions at gitbox.apache.org to link your GitHub account
    with your Apache account.

You will then have write (but not admin) access to the DataFusion repositories.
If you have questions or run into issues, please reply-all to this e-mail.

@adriangb
Copy link
Contributor

adriangb commented Jun 5, 2025

Ah I was waiting for the email but in reality I just missed it 😄

@adriangb adriangb merged commit 25727d4 into apache:main Jun 5, 2025
27 checks passed
@adriangb
Copy link
Contributor

adriangb commented Jun 5, 2025

Worked!! Sweet. Thank you Andrew (for the fix and nudge).

@alamb
Copy link
Contributor Author

alamb commented Jun 5, 2025

WOOHOO 🚀

@alamb alamb deleted the alamb/rexports branch June 5, 2025 19:55
kosiew pushed a commit to kosiew/datafusion that referenced this pull request Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants