-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Reapply "Ignore sort_query_fuzzer_runner
(#16462)" (#16470)
#16485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
) This reverts commit a0eaf51.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😀
Thanks @blaginin I am merging this in to get main back clean again |
We could also set |
Does that solve the issue? It didn't seem to in the last thread we had on it. If it does yes I think that's better than reverting the PR. Maybe we should do that out of caution regardless. |
I don't think we should revert the PR given there is a way to turn it off -- let's just keep debugging on main. I'll try and find time over the weekend / next week if it is still unsolved |
Basically from what I can tell we don't really know what the root cause is |
I'm trying to reproduce locally first by running it 100 times and recording failure rate. I just ran it and got 0 failures. Not sure if this is expected or not. I'll push a branch to CI and try to get it to fail -> commit the revert -> no failures. |
Second local run I got 4/100 failures. What a flake. |
😱 |
😭 |
Is this before the suspect PR? |
I think it was after and I had made some edits to try to locate the section of code producing the but. But the comment was just to make the point of how flakey this is. Let's continue discussion in #16452 |
This reverts commit a0eaf51.
Which issue does this PR close?
Rationale for this change
sort_query_fuzzer_runner
(#16462)" #16470However, then the test failed again when we re-enabled it:
https://github.com/apache/datafusion/actions/runs/15780623790/job/44485106315
Let's revert the revert
What changes are included in this PR?
Re-disable the test on main while we sort out the root cause
Are these changes tested?
Are there any user-facing changes?