Remove ObjectStore from FileScanConfig and ListingTableConfig #2668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
github-actions
bot
added
the
development-process
alamb
approved these changes
Jun 1, 2022
| @@ -105,10 +99,12 @@ impl ListingTableConfig { | |||
| } | |||
|
|
|||
| /// Infer `ListingOptions` based on `table_path` suffix. | |||
| pub async fn infer_options(self) -> Result<Self> { | |||
| pub async fn infer_options(self, ctx: &SessionState) -> Result<Self> { | |||
| let store = ctx.runtime_env.object_store(&self.table_path)?; | |||
| let mock_store = | ||
| TestObjectStore::new_arc(&files.iter().map(|f| (*f, 10)).collect::<Vec<_>>()); | ||
| let ctx = SessionContext::new(); | ||
| register_test_store(&ctx, &files.iter().map(|f| (*f, 10)).collect::<Vec<_>>()); |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #2489
Rationale for this change
Manually plumbing the ObjectStore around introduces the potential for inconsistency, increases code complexity, and complicates plan serialization.
What changes are included in this PR?
Follows on from #2578 (comment) and removes the ObjectStore from FileScanConfig and ListingTableConfig, instead determining them as needed from the session context.
Are there any user-facing changes?
Yes, this changes the API of FileScanConfig and ListingTableConfig.
Does this PR break compatibility with Ballista?
Probably...