Skip to content

Conversation

@GWphua
Copy link
Contributor

@GWphua GWphua commented Nov 28, 2025

Attempt at #18781 .

Description

Remove GroupByStatsProvider.PerQueryStats

  • Implement groupby metrics reporting in GroupByQueryMetrics.
  • Replace usages of GroupByStatsProvider.PerQueryStats with either QueryPlus or GroupByQueryMetrics.
  • Update all method signatures in the codebase which rely on GroupByStatsProvider or PerQueryStats.
  • Update GroupByStatsProvider Test.

TODOs

  • Verify metrics emission through MetricsEmittingQueryRunner.
  • Verify metrics emitted are the same as the previous GroupByStatsProvider#PerQueryStats.
  • Come up with new metric names, current metrics names clash with GroupByStatsMonitor.

Release note

TODO.


Key changed/added classes in this PR

TODO.

  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@GWphua GWphua marked this pull request as draft November 28, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant