Skip to content

Conversation

@jtuglu1
Copy link
Contributor

@jtuglu1 jtuglu1 commented Dec 5, 2025

Description

Vectorizes SpectatorHistogram.

Performance

Need to do real-world testing (TODO), but benchmarks are promising (>10x speed-up):

Benchmark                                                    (metricName)  (rowsPerSegment)  (vectorize)  Mode  Cnt      Score   Error  Units
SpectatorHistogramAggregatorBenchmark.queryIncrementalIndex         long1           1000000        false  avgt    2  92451.646          us/op
SpectatorHistogramAggregatorBenchmark.queryIncrementalIndex         long1           1000000         true  avgt    2  73224.875          us/op
SpectatorHistogramAggregatorBenchmark.queryQueryableIndex           long1           1000000        false  avgt    2   3776.303          us/op
SpectatorHistogramAggregatorBenchmark.queryQueryableIndex           long1           1000000         true  avgt    2    202.916          us/op

Other perf ideas

  • Possibly apply some fixed step loop unrolling to save even more instructions.

Release note


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@jtuglu1 jtuglu1 marked this pull request as draft December 5, 2025 07:28
@jtuglu1
Copy link
Contributor Author

jtuglu1 commented Dec 5, 2025

Test failure is unrelated and being fixed in #18814

@jtuglu1 jtuglu1 force-pushed the spectator-histogram-vectorize branch 2 times, most recently from 52e3ace to a400531 Compare December 5, 2025 20:04
@jtuglu1 jtuglu1 force-pushed the spectator-histogram-vectorize branch from a400531 to 48516d9 Compare December 5, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant