Set the default latchable emitter timeout to 20 seconds in ForcePushDownNestedQueryTest
#18816
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MSQ query appearst to take longer than 10s. Other tests like QueryVirtualStorageTest and EmbeddedDurableShuffleStorageTest that use the same query use 20s timeout, so that should help. Also, include the timeout in the error message so it's clear rather than having to look at the stacktrace.
10 tasks
Contributor
|
@abhishekrb19 , seems like it failed on this PR #18820 too. Should we try upping it to 30s? |
Contributor
Author
|
@kfaraz I think 18820 doesn’t include this patch. The log line in the run you linked doesn't include the timeout: |
Contributor
|
Ah, thanks for the clarification @abhishekrb19 ! Let me double check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ForcePushDownNestedQueryTestis occasionally flaky on master because the MSQ query inloadWikipediaTable()can take longer than the default 10 second timeout to finish and for segments to be loaded and available. Other tests such asQueryVirtualStorageTestandEmbeddedDurableShuffleStorageTestuse a 20 second timeout for similar loads, so increasing the timeout here to 20 seconds should address the flakiness. See the failed run: https://github.com/apache/druid/actions/runs/19955328339/job/57225328413