Take CR comments

Author: arunkumarchacko

hadoop-tools/hadoop-gcp/src/main/java/org/apache/hadoop/fs/gs/GoogleCloudStorageClientReadChannel.java

@@ -61,7 +61,6 @@ class GoogleCloudStorageClientReadChannel implements SeekableByteChannel {
 
   // The size of this object generation, in bytes.
   private long objectSize;
-//  private final ErrorTypeExtractor errorExtractor;
   private ContentReadChannel contentReadChannel;
   private boolean gzipEncoded = false;
   private boolean open = true;

hadoop-tools/hadoop-gcp/src/main/java/org/apache/hadoop/fs/gs/GoogleCloudStorageFileSystem.java

@@ -448,8 +448,10 @@ void rename(URI src, URI dst) throws IOException {
   private void renameObject(URI src, URI dst, FileInfo srcInfo) throws IOException {
     StorageResourceId srcResourceId =
         StorageResourceId.fromUriPath(src, /* allowEmptyObjectName= */ true);
-    StorageResourceId dstResourceId =
-        StorageResourceId.fromUriPath(dst, /* allowEmptyObjectName= */ true, /* generationId= */ 0L);
+    StorageResourceId dstResourceId = StorageResourceId.fromUriPath(
+        dst,
+        /* allowEmptyObjectName= */ true,
+        /* generationId= */ 0L);
 
     if (srcResourceId.getBucketName().equals(dstResourceId.getBucketName())) {
       gcs.move(

hadoop-tools/hadoop-gcp/src/main/java/org/apache/hadoop/fs/gs/GoogleHadoopFileSystemConfiguration.java

@@ -182,7 +182,8 @@ public Pattern getMarkerFilePattern() {
     }
 
     if (fileMarkerFilePattern == null) {
-      this.fileMarkerFilePattern =  Pattern.compile("^(.+/)?" + pattern + "$");
+      // Caching the pattern since compile step can be expensive
+      fileMarkerFilePattern =  Pattern.compile("^(.+/)?" + pattern + "$");
     }
 
     return fileMarkerFilePattern;

hadoop-tools/hadoop-gcp/src/main/java/org/apache/hadoop/fs/gs/Gs.java

@@ -61,6 +61,4 @@ protected void finalize() throws Throwable {
     fsImpl.close();
     super.finalize();
   }
-}
-
-
+}