HDFS-11114. Support for running async disk checks in DataNode. #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ib21cd21fe9b67ca35b38f8462c138e90b55f33df
anuengineer
reviewed
Nov 7, 2016
| * | ||
| * @throws InterruptedException | ||
| */ | ||
| void join(long timeout, TimeUnit timeUnit) throws InterruptedException; |
There was a problem hiding this comment.
Just trying to understand this a little better, From the signature and implementation this function looks more a awaitTermination in executorService. That is this function will wait for a while and cancel and task if the timeout occurs, in that case would you consider calling this await or awaitTermination. Java "join" seems to imply a wait without timeouts. Just making sure that the intended was indeed a shutdown/await pattern.
There was a problem hiding this comment.
Thanks for taking a look @anuengineer. The method covers both shutdown and awaitTermination semantics. I could call it shutdownAndAwaitTermination() to make it clearer.
Change-Id: I3b6dd71f2421b6703fc09b0f3491bd3e18bbf898
|
Renamed it to shutdownAndWait. |
anuengineer
approved these changes
Nov 7, 2016
asfgit
pushed a commit
that referenced
this pull request
Nov 8, 2016
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…kController Addresses the following: * Makes LeaderElectionListener to be explicitly registered by the caller * Removes debouncetimer dependency from ZkLeaderElector implementation * [Bug] onBecomeLeader was scheduling a task in timer under "OnBecomeLeader", when it should actually be the same as "OnProcessorChange". Otherwise, it will not cancel when there is a new OnProcessorChange event. * [Transient Test Failure] `TestScheduleAfterDebounceTime` tests were relying on timing controlled by sleep. Fixed it by using latch Author: Navina Ramesh <[email protected]> Reviewers: Xinyu Liu <[email protected]>, Boris Shkolnik <[email protected]> Closes apache#153 from navina/SAMZA-1251
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…bounceTimer This PR depends on PR apache#153 * Treats all errors in jobcoordinator as FATAL and shuts-down the streamprocessor * [Bug] Fixed bug reported in SAMZA-1241 * Introduced a callback to be associated with the timer (same callback for every Runnable failure) **TBD**: some more unit tests Author: Navina Ramesh <[email protected]> Reviewers: Xinyu Liu <[email protected]>, Prateek Maheshwari <[email protected]> Closes apache#166 from navina/SAMZA-1150
This was referenced Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interface for running async checks on a resource.
The implementation ThrottledAsyncChecker supports throttling and result-caching. DataNode changes to use it will be done in another Jira.