Skip to content

HADOOP-17040. Fix intermittent failure of ITestBlockingThreadPoolExecutorService. #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2020

Conversation

iwasakims
Copy link
Member

The testSubmitRunnable expects work queue is filled and subsequent submit will be blocked for certain time. This may not be satisfiled depending on load on the test machine. We can make the situation certain by using CountDownLatch.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 19m 28s trunk passed
+1 💚 compile 0m 36s trunk passed
+1 💚 checkstyle 0m 27s trunk passed
+1 💚 mvnsite 0m 39s trunk passed
+1 💚 shadedclient 15m 9s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 31s trunk passed
+0 🆗 spotbugs 1m 0s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 0m 58s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 32s the patch passed
+1 💚 compile 0m 28s the patch passed
+1 💚 javac 0m 28s the patch passed
+1 💚 checkstyle 0m 18s the patch passed
+1 💚 mvnsite 0m 32s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 13m 37s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 26s the patch passed
+1 💚 findbugs 1m 2s the patch passed
_ Other Tests _
+1 💚 unit 1m 14s hadoop-aws in the patch passed.
+1 💚 asflicense 0m 32s The patch does not generate ASF License warnings.
58m 30s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2020/1/artifact/out/Dockerfile
GITHUB PR #2020
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 72f8c8f3b3d1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 743c2e9
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2020/1/testReport/
Max. process+thread count 459 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2020/1/console
versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@aajisaka
Copy link
Member

+1, the CountDownLatch works as expected.

For testing, I inserted Thread.sleep(3000) after latch.countDown() to empty the queue and verified that assertDidBlock(stopWatch) throws RuntimeException.

@aajisaka aajisaka self-requested a review May 22, 2020 06:23
@aajisaka
Copy link
Member

I'm not sure why the test is in hadoop-aws module. I think it should be in hadoop-common because this test calls hadoop-common module only.

@iwasakims
Copy link
Member Author

I think it should be in hadoop-common because this test calls hadoop-common module only.

Sure. I will check the history and file follow-up jira if it turns out to be just histrical one. Thanks, @aajisaka .

@iwasakims iwasakims merged commit 9685314 into apache:trunk May 22, 2020
asfgit pushed a commit that referenced this pull request May 22, 2020
asfgit pushed a commit that referenced this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants