HADOOP-19083. hadoop binaries aws sdk unless -Pawssdk builds #6570

steveloughran · 2024-02-21T20:26:26Z

New profile awssdk must be set for hadoop-tools-dist to include the AWS SDK (so cuts binary size in half)

This is not yet documented
no attempt to be clever in LICENSE-binary and remove the declaration.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2024-02-21T22:27:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 31s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	44m 17s		trunk passed
+1 💚	compile	0m 25s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 24s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	mvnsite	0m 30s		trunk passed
+1 💚	javadoc	0m 30s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 24s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	shadedclient	78m 48s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 17s		the patch passed
+1 💚	compile	0m 14s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 14s		the patch passed
+1 💚	compile	0m 15s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	0m 15s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 17s		the patch passed
+1 💚	javadoc	0m 16s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 15s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	shadedclient	33m 51s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 19s		hadoop-tools-dist in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		119m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6570/1/artifact/out/Dockerfile
GITHUB PR	#6570
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname	Linux d60acba26022 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `31f9a71`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6570/1/testReport/
Max. process+thread count	691 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-tools-dist U: hadoop-tools/hadoop-tools-dist
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6570/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

steveloughran · 2024-04-19T11:17:24Z

we may want to merge this for anyone doing lightweight local builds, but for our own releases it is better just to make some lean tarballs where we strip out the bundle.jar file, just as we swap over the arm64 binaries.

mukund-thakur

shouldn't create release be modified to use -Pawssdk ?

dev-support/bin/create-release

steveloughran · 2024-08-15T12:23:21Z

let me rebase.

I was thinking it'd be better to just generate a .tar.gz with the aws sdk stripped from it. that way: one build, identical binaries

New profile awssdk must be set for hadoop-tools-dist to include the AWS SDK (so cuts binary size in half) This is not yet documented Change-Id: I1d7808d82f172e861348af1ab7c6bae46590dcb9

* update building doc * LICENSE-binary makes clear it is optional * hadoop s3guard bucket-info tool reports error better * docs cover how to install. It's actually quite hard to manually install; unless we can give better instructions I almost think we'd want to create releases with and without the AWS SDK. Let's target 3.4.1 for that Change-Id: I2c91963a21b5c289e05218c2cbce0561b8e48b60

Change-Id: I29309cc76ccf4c214f112d2245aab7713a430063

hadoop-yetus · 2024-08-16T08:57:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	markdownlint	0m 0s		markdownlint was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 21s		Maven dependency ordering for branch
+1 💚	mvninstall	36m 40s		trunk passed
+1 💚	compile	19m 35s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	compile	17m 49s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	checkstyle	4m 57s		trunk passed
+1 💚	mvnsite	27m 1s		trunk passed
+1 💚	javadoc	9m 11s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	8m 0s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+0 🆗	spotbugs	0m 20s		branch/hadoop-tools/hadoop-tools-dist no spotbugs output file (spotbugsXml.xml)
-1 ❌	spotbugs	32m 49s	/branch-spotbugs-root-warnings.html	root in trunk has 2 extant spotbugs warnings.
+1 💚	shadedclient	71m 9s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 31s		Maven dependency ordering for patch
+1 💚	mvninstall	35m 39s		the patch passed
+1 💚	compile	19m 7s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javac	19m 7s		the patch passed
+1 💚	compile	17m 43s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	javac	17m 43s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	4m 42s		the patch passed
+1 💚	mvnsite	20m 16s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	9m 5s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	7m 55s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+0 🆗	spotbugs	0m 20s		hadoop-tools/hadoop-tools-dist has no data from spotbugs
+1 💚	shadedclient	72m 12s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	818m 46s		root in the patch passed.
+1 💚	asflicense	1m 41s		The patch does not generate ASF License warnings.
		1226m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6570/3/artifact/out/Dockerfile
GITHUB PR	#6570
Optional Tests	dupname asflicense codespell detsecrets compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle markdownlint xmllint shellcheck shelldocs
uname	Linux 0fcb0c404a1c 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `092c780`
Default Java	Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6570/3/testReport/
Max. process+thread count	3582 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-aws hadoop-tools/hadoop-tools-dist . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6570/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-08-16T09:30:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 34s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	markdownlint	0m 0s		markdownlint was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	36m 40s		trunk passed
+1 💚	compile	19m 12s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	compile	17m 25s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	checkstyle	4m 57s		trunk passed
+1 💚	mvnsite	26m 6s		trunk passed
+1 💚	javadoc	9m 11s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	8m 18s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+0 🆗	spotbugs	0m 22s		branch/hadoop-tools/hadoop-tools-dist no spotbugs output file (spotbugsXml.xml)
-1 ❌	spotbugs	33m 11s	/branch-spotbugs-root-warnings.html	root in trunk has 2 extant spotbugs warnings.
+1 💚	shadedclient	68m 1s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 33s		Maven dependency ordering for patch
+1 💚	mvninstall	35m 9s		the patch passed
+1 💚	compile	18m 6s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javac	18m 6s		the patch passed
+1 💚	compile	17m 19s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	javac	17m 19s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	4m 41s		the patch passed
+1 💚	mvnsite	21m 6s		the patch passed
+1 💚	shellcheck	0m 1s		No new issues.
+1 💚	javadoc	9m 9s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	8m 26s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+0 🆗	spotbugs	0m 22s		hadoop-tools/hadoop-tools-dist has no data from spotbugs
+1 💚	shadedclient	72m 9s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	764m 16s		root in the patch passed.
+1 💚	asflicense	1m 39s		The patch does not generate ASF License warnings.
		1167m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6570/4/artifact/out/Dockerfile
GITHUB PR	#6570
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle markdownlint xmllint
uname	Linux e508c099995a 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `268654b`
Default Java	Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6570/4/testReport/
Max. process+thread count	3983 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-aws hadoop-tools/hadoop-tools-dist . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6570/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

github-actions bot added build trunk TOOLS labels Feb 21, 2024

steveloughran force-pushed the s3/HADOOP-19083-tar-exclude-aws-sdk branch from 31f9a71 to 1cd2bcd Compare February 22, 2024 18:10

github-actions bot added AWS Infra labels Feb 22, 2024

steveloughran marked this pull request as draft March 15, 2024 14:40

mukund-thakur reviewed Aug 14, 2024

View reviewed changes

dev-support/bin/create-release Outdated Show resolved Hide resolved

steveloughran added 2 commits August 15, 2024 13:24

HADOOP-19083. hadoop binaries aws sdk unless -Pawssdk builds

70273da

New profile awssdk must be set for hadoop-tools-dist to include the AWS SDK (so cuts binary size in half) This is not yet documented Change-Id: I1d7808d82f172e861348af1ab7c6bae46590dcb9

steveloughran force-pushed the s3/HADOOP-19083-tar-exclude-aws-sdk branch from 1cd2bcd to 092c780 Compare August 15, 2024 12:29

HADOOP-19083. Add --aws-sdk option to create-release command

268654b

Change-Id: I29309cc76ccf4c214f112d2245aab7713a430063

steveloughran closed this Oct 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HADOOP-19083. hadoop binaries aws sdk unless -Pawssdk builds #6570

HADOOP-19083. hadoop binaries aws sdk unless -Pawssdk builds #6570

Uh oh!

steveloughran commented Feb 21, 2024

Uh oh!

hadoop-yetus commented Feb 21, 2024

Uh oh!

steveloughran commented Apr 19, 2024

Uh oh!

mukund-thakur left a comment

Uh oh!

Uh oh!

steveloughran commented Aug 15, 2024

Uh oh!

hadoop-yetus commented Aug 16, 2024

Uh oh!

hadoop-yetus commented Aug 16, 2024

Uh oh!

Uh oh!

HADOOP-19083. hadoop binaries aws sdk unless -Pawssdk builds #6570

HADOOP-19083. hadoop binaries aws sdk unless -Pawssdk builds #6570

Uh oh!

Conversation

steveloughran commented Feb 21, 2024

For code changes:

Uh oh!

hadoop-yetus commented Feb 21, 2024

Uh oh!

steveloughran commented Apr 19, 2024

Uh oh!

mukund-thakur left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

steveloughran commented Aug 15, 2024

Uh oh!

hadoop-yetus commented Aug 16, 2024

Uh oh!

hadoop-yetus commented Aug 16, 2024

Uh oh!

Uh oh!