Commit to remove vulnerabilities raised for: HADOOP-19074 #6586
+30
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Update Gauva to Version: 32.0.1-jre 2) Update Protobuf to Version: 3.21.12 2) Update Avro to Version: 1.11.3 4) Updated private access in the below files for Avro compability: - hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/serializer/avro/TestAvroSerialization.java - hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobQueueChangeEvent.java - hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/JobBuilder.java - hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/JobHistoryUtils.java - hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedTask.java - hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java
|
💔 -1 overall
This message was automatically generated. |
dineshchitlangia
requested changes
Feb 29, 2024
There was a problem hiding this comment.
Hi @prathapsagar , thank you for contributing this improvement.
Could you pls address the checkstyle violation?
Thank you.
…/test/java/org/apache/hadoop/io/serializer/avro/TestAvroSerialization.java
|
Hi @dineshchitlangia I have resolved the check style violation and raised a new PR with the changes please validate: #6586 |
|
💔 -1 overall
This message was automatically generated. |
steveloughran
requested changes
Mar 1, 2024
There was a problem hiding this comment.
each artifact updatate needs to be managed separately so we can rollback. that even includes a surefire update.
anything where we fix up to the shaded dependencies in hadoop-thirdparty need to go in there first and we can then cut a new version of that for 3.4.1.
for avro, we should look at cutting the unshaded version entirely. do we need to publish it?
| @@ -151,7 +151,7 @@ | |||
| <protobuf-maven-plugin.version>0.5.1</protobuf-maven-plugin.version> | |||
| <maven-replacer-plugin.version>1.5.3</maven-replacer-plugin.version> | |||
|
|
|||
| <protobuf-compile.version>3.5.1</protobuf-compile.version> | |||
| <protobuf-compile.version>3.16.3</protobuf-compile.version> | |||
There was a problem hiding this comment.
obsoleted by HADOOP-19065. Update Protocol Buffers installation to 3.21.12 (#6526); needs a version change in hadoop-thirdparty which MUST come out before changing things here.
| @@ -169,7 +169,7 @@ | |||
|
|
|||
| <!-- Plugin versions and config --> | |||
| <maven-surefire-plugin.argLine>-Xmx2048m -XX:+HeapDumpOnOutOfMemoryError</maven-surefire-plugin.argLine> | |||
| <maven-surefire-plugin.version>3.0.0-M1</maven-surefire-plugin.version> | |||
| <maven-surefire-plugin.version>3.2.5</maven-surefire-plugin.version> | |||
There was a problem hiding this comment.
tried that and already had to revert. Now, if you are offering to fix all the test failures which surfaced, you can try again.
HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5. (#6537)" (#6578)
|
@prathapsagar thanks for starting this. you are about to discover why it so hard to update dependencies. Everything we want to use in our own code should be defined in the thirdparty module, https://github.com/apache/hadoop-thirdparty the version numbers of things like protobuf in our own code must match those of the library version we build with, but they aren't where the values are incremented. (note: we should add comments there). |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?