HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part2. #7347

slfan1989 · 2025-02-04T02:30:12Z

Description of PR

JIRA: HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part2.

How was this patch tested?

Junit Test & mvn clean test.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2025-02-04T03:12:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	25m 14s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 2s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 99 new or modified test files.
			_ trunk Compile Tests _
-1 ❌	mvninstall	0m 25s	/branch-mvninstall-root.txt	root in trunk failed.
-1 ❌	compile	0m 24s	/branch-compile-root-jdkUbuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04.txt	root in trunk failed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04.
-1 ❌	compile	0m 24s	/branch-compile-root-jdkPrivateBuild-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga.txt	root in trunk failed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga.
-0 ⚠️	checkstyle	0m 22s	/buildtool-branch-checkstyle-hadoop-common-project_hadoop-common.txt	The patch fails to run checkstyle in hadoop-common
-1 ❌	mvnsite	0m 24s	/branch-mvnsite-hadoop-common-project_hadoop-common.txt	hadoop-common in trunk failed.
-1 ❌	javadoc	0m 24s	/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04.txt	hadoop-common in trunk failed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04.
-1 ❌	javadoc	0m 24s	/branch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga.txt	hadoop-common in trunk failed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga.
-1 ❌	spotbugs	0m 24s	/branch-spotbugs-hadoop-common-project_hadoop-common.txt	hadoop-common in trunk failed.
+1 💚	shadedclient	2m 52s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
-1 ❌	mvninstall	0m 24s	/patch-mvninstall-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch failed.
-1 ❌	compile	0m 25s	/patch-compile-root-jdkUbuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04.txt	root in the patch failed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04.
-1 ❌	javac	0m 25s	/patch-compile-root-jdkUbuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04.txt	root in the patch failed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04.
-1 ❌	compile	0m 25s	/patch-compile-root-jdkPrivateBuild-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga.txt	root in the patch failed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga.
-1 ❌	javac	0m 25s	/patch-compile-root-jdkPrivateBuild-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga.txt	root in the patch failed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga.
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 9 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	0m 23s	/buildtool-patch-checkstyle-hadoop-common-project_hadoop-common.txt	The patch fails to run checkstyle in hadoop-common
-1 ❌	mvnsite	0m 25s	/patch-mvnsite-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch failed.
-1 ❌	javadoc	0m 26s	/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04.txt	hadoop-common in the patch failed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04.
-1 ❌	javadoc	0m 23s	/patch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga.txt	hadoop-common in the patch failed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga.
-1 ❌	spotbugs	0m 24s	/patch-spotbugs-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch failed.
-1 ❌	shadedclient	6m 6s		patch has errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	0m 24s	/patch-unit-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch failed.
+1 💚	asflicense	0m 58s		The patch does not generate ASF License warnings.
		40m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7347/1/artifact/out/Dockerfile
GITHUB PR	#7347
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux fe4beefe4a02 5.15.0-125-generic #135-Ubuntu SMP Fri Sep 27 13:53:58 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `57a17cb`
Default Java	Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7347/1/testReport/
Max. process+thread count	46 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7347/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2025-02-04T13:49:35Z

@cnauroth Can you help review this PR? Thank you very much!

hadoop-yetus · 2025-02-04T15:10:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 2s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 99 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	40m 40s		trunk passed
+1 💚	compile	19m 20s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	compile	17m 19s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	checkstyle	1m 22s		trunk passed
+1 💚	mvnsite	1m 36s		trunk passed
+1 💚	javadoc	1m 14s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 52s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	2m 32s		trunk passed
+1 💚	shadedclient	40m 37s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 1s		the patch passed
+1 💚	compile	19m 23s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javac	19m 23s		the patch passed
+1 💚	compile	17m 50s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	javac	17m 50s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 57 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	1m 17s	/results-checkstyle-hadoop-common-project_hadoop-common.txt	hadoop-common-project/hadoop-common: The patch generated 82 new + 849 unchanged - 46 fixed = 931 total (was 895)
+1 💚	mvnsite	1m 34s		the patch passed
+1 💚	javadoc	1m 9s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 47s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	2m 56s		the patch passed
+1 💚	shadedclient	43m 47s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	4m 10s	/patch-unit-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch passed.
+1 💚	asflicense	1m 2s		The patch does not generate ASF License warnings.
		222m 3s

Reason	Tests
Failed junit tests	hadoop.fs.viewfs.TestViewFSOverloadSchemeCentralMountTableConfig

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7347/2/artifact/out/Dockerfile
GITHUB PR	#7347
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux bae65beca68c 5.15.0-125-generic #135-Ubuntu SMP Fri Sep 27 13:53:58 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `08ff51a`
Default Java	Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7347/2/testReport/
Max. process+thread count	530 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7347/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2025-02-04T17:20:01Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 52s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 2s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 99 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	43m 14s		trunk passed
+1 💚	compile	20m 24s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	compile	18m 36s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	checkstyle	1m 21s		trunk passed
+1 💚	mvnsite	1m 37s		trunk passed
+1 💚	javadoc	1m 13s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 50s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	2m 45s		trunk passed
+1 💚	shadedclient	40m 49s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 54s		the patch passed
+1 💚	compile	18m 36s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javac	18m 36s		the patch passed
+1 💚	compile	17m 14s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	javac	17m 14s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 72 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	1m 18s	/results-checkstyle-hadoop-common-project_hadoop-common.txt	hadoop-common-project/hadoop-common: The patch generated 44 new + 849 unchanged - 46 fixed = 893 total (was 895)
+1 💚	mvnsite	1m 36s		the patch passed
+1 💚	javadoc	1m 8s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 52s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	2m 37s		the patch passed
+1 💚	shadedclient	41m 9s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	3m 56s	/patch-unit-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch passed.
+1 💚	asflicense	1m 1s		The patch does not generate ASF License warnings.
		223m 9s

Reason	Tests
Failed junit tests	hadoop.fs.viewfs.TestViewFSOverloadSchemeCentralMountTableConfig

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7347/3/artifact/out/Dockerfile
GITHUB PR	#7347
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux 26e2ea5164e3 5.15.0-125-generic #135-Ubuntu SMP Fri Sep 27 13:53:58 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `f5f0159`
Default Java	Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7347/3/testReport/
Max. process+thread count	524 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7347/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

cnauroth

Changes look good!

[ERROR] Failures: 
[ERROR] org.apache.hadoop.fs.viewfs.TestViewFSOverloadSchemeCentralMountTableConfig.testLocalFsLinkSlashMergeWithOtherMountLinks
[ERROR]   Run 1: TestViewFSOverloadSchemeCentralMountTableConfig>TestViewFileSystemOverloadSchemeLocalFileSystem.testLocalFsLinkSlashMergeWithOtherMountLinks:149 Unexpected exception type thrown ==> expected: <java.io.IOException> but was: <java.lang.NullPointerException>
[ERROR]   Run 2: TestViewFSOverloadSchemeCentralMountTableConfig>TestViewFileSystemOverloadSchemeLocalFileSystem.testLocalFsLinkSlashMergeWithOtherMountLinks:149 Unexpected exception type thrown ==> expected: <java.io.IOException> but was: <java.lang.NullPointerException>
[ERROR]   Run 3: TestViewFSOverloadSchemeCentralMountTableConfig>TestViewFileSystemOverloadSchemeLocalFileSystem.testLocalFsLinkSlashMergeWithOtherMountLinks:149 Unexpected exception type thrown ==> expected: <java.io.IOException> but was: <java.lang.NullPointerException>
[INFO] 
[ERROR] Errors: 
[ERROR] org.apache.hadoop.fs.viewfs.TestViewFSOverloadSchemeCentralMountTableConfig.testLocalFsCreateAndDelete
[ERROR]   Run 1: TestViewFSOverloadSchemeCentralMountTableConfig>TestViewFileSystemOverloadSchemeLocalFileSystem.testLocalFsCreateAndDelete:113->addMountLinks:67 NullPointer
[ERROR]   Run 2: TestViewFSOverloadSchemeCentralMountTableConfig>TestViewFileSystemOverloadSchemeLocalFileSystem.testLocalFsCreateAndDelete:113->addMountLinks:67 NullPointer
[ERROR]   Run 3: TestViewFSOverloadSchemeCentralMountTableConfig>TestViewFileSystemOverloadSchemeLocalFileSystem.testLocalFsCreateAndDelete:113->addMountLinks:67 NullPointer
[INFO] 
[ERROR] org.apache.hadoop.fs.viewfs.TestViewFSOverloadSchemeCentralMountTableConfig.testLocalFsLinkSlashMerge
[ERROR]   Run 1: TestViewFSOverloadSchemeCentralMountTableConfig>TestViewFileSystemOverloadSchemeLocalFileSystem.testLocalFsLinkSlashMerge:132->addMountLinks:67 NullPointer
[ERROR]   Run 2: TestViewFSOverloadSchemeCentralMountTableConfig>TestViewFileSystemOverloadSchemeLocalFileSystem.testLocalFsLinkSlashMerge:132->addMountLinks:67 NullPointer
[ERROR]   Run 3: TestViewFSOverloadSchemeCentralMountTableConfig>TestViewFileSystemOverloadSchemeLocalFileSystem.testLocalFsLinkSlashMerge:132->addMountLinks:67 NullPointer
[INFO] 
[ERROR] org.apache.hadoop.fs.viewfs.TestViewFSOverloadSchemeCentralMountTableConfig.testLocalTargetLinkWriteSimple
[ERROR]   Run 1: TestViewFSOverloadSchemeCentralMountTableConfig>TestViewFileSystemOverloadSchemeLocalFileSystem.testLocalTargetLinkWriteSimple:93->addMountLinks:67 NullPointer
[ERROR]   Run 2: TestViewFSOverloadSchemeCentralMountTableConfig>TestViewFileSystemOverloadSchemeLocalFileSystem.testLocalTargetLinkWriteSimple:93->addMountLinks:67 NullPointer
[ERROR]   Run 3: TestViewFSOverloadSchemeCentralMountTableConfig>TestViewFileSystemOverloadSchemeLocalFileSystem.testLocalTargetLinkWriteSimple:93->addMountLinks:67 NullPointer

TestViewFSOverloadSchemeCentralMountTableConfig is a subclass of TestViewFileSystemOverloadSchemeLocalFileSystem. In your patch, the base class has been converted to JUnit 5 with the Jupiter annotations. The subclass though is still using org.junit.Before, so maybe its test setup is not getting triggered. Do we need to convert that one to org.junit.jupiter.api.BeforeEach?

slfan1989 · 2025-02-05T01:53:19Z

TestViewFSOverloadSchemeCentralMountTableConfig is a subclass of TestViewFileSystemOverloadSchemeLocalFileSystem. In your patch, the base class has been converted to JUnit 5 with the Jupiter annotations. The subclass though is still using org.junit.Before, so maybe its test setup is not getting triggered. Do we need to convert that one to org.junit.jupiter.api.BeforeEach?

@cnauroth Thank you very much for reviewing the code! This is an issue we are already aware of—there are some abstract test classes in hadoop-common that are used by multiple modules, such as hadoop-azure, hadoop-aws, hadoop-distcp, etc. Our plan is to first upgrade the parts without dependencies, and then submit a unified PR to handle the dependent parts. Additionally, I will fix the checkstyle and blank issues. We hope that the feedback from Yetus will be positive, and the build will pass successfully.

The fix using the method you provided is fine. We will replace it with beforeEach, and this test class and its parent class are not referenced by any other modules. I will go ahead and fix it.

hadoop-yetus · 2025-02-05T06:16:32Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 2s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 100 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	40m 35s		trunk passed
+1 💚	compile	19m 22s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	compile	17m 12s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	checkstyle	1m 24s		trunk passed
+1 💚	mvnsite	1m 34s		trunk passed
+1 💚	javadoc	1m 14s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 51s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	2m 34s		trunk passed
+1 💚	shadedclient	40m 32s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 54s		the patch passed
+1 💚	compile	18m 20s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javac	18m 20s		the patch passed
+1 💚	compile	17m 15s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	javac	17m 15s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 4 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	1m 20s	/results-checkstyle-hadoop-common-project_hadoop-common.txt	hadoop-common-project/hadoop-common: The patch generated 31 new + 849 unchanged - 46 fixed = 880 total (was 895)
+1 💚	mvnsite	1m 36s		the patch passed
+1 💚	javadoc	1m 10s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 52s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	2m 39s		the patch passed
+1 💚	shadedclient	41m 47s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	5m 14s		hadoop-common in the patch passed.
+1 💚	asflicense	1m 2s		The patch does not generate ASF License warnings.
		219m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7347/4/artifact/out/Dockerfile
GITHUB PR	#7347
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux eb942c49c2f1 5.15.0-125-generic #135-Ubuntu SMP Fri Sep 27 13:53:58 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `cf57acb`
Default Java	Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7347/4/testReport/
Max. process+thread count	540 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7347/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2025-02-05T12:55:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 100 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	40m 11s		trunk passed
+1 💚	compile	19m 8s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	compile	17m 21s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	checkstyle	1m 23s		trunk passed
+1 💚	mvnsite	1m 39s		trunk passed
+1 💚	javadoc	1m 14s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 51s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	2m 33s		trunk passed
+1 💚	shadedclient	40m 45s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 54s		the patch passed
+1 💚	compile	18m 22s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javac	18m 22s		the patch passed
+1 💚	compile	17m 22s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	javac	17m 22s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 18s		hadoop-common-project/hadoop-common: The patch generated 0 new + 849 unchanged - 46 fixed = 849 total (was 895)
+1 💚	mvnsite	1m 38s		the patch passed
+1 💚	javadoc	1m 11s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 51s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	2m 39s		the patch passed
+1 💚	shadedclient	41m 36s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	5m 16s		hadoop-common in the patch passed.
+1 💚	asflicense	1m 1s		The patch does not generate ASF License warnings.
		219m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7347/5/artifact/out/Dockerfile
GITHUB PR	#7347
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux acc7c18476b1 5.15.0-125-generic #135-Ubuntu SMP Fri Sep 27 13:53:58 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `6a873c9`
Default Java	Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7347/5/testReport/
Max. process+thread count	588 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7347/5/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

cnauroth

+1

Thank you, @slfan1989 !

slfan1989 · 2025-02-05T21:07:22Z

+1

Thank you, @slfan1989 !

@cnauroth Thank you very much for reviewing the code! I will merge this PR into the trunk branch and begin submitting the code for PART3.

cnauroth · 2025-02-05T21:58:57Z

I just noticed that some tests are no longer running after this patch, e.g. TestRawlocalContractOpen. I'm working around it locally by adding the vintage dependency:

    <dependency>
      <groupId>org.junit.vintage</groupId>
      <artifactId>junit-vintage-engine</artifactId>
      <scope>test</scope>
    </dependency>

@slfan1989 , I guess the other upcoming hadoop-common patches will address remaining conversions like these file system contract tests?

…2. (apache#7347) Co-authored-by: Chris Nauroth <[email protected]> Reviewed-by: Chris Nauroth <[email protected]> Signed-off-by: Shilun Fan <[email protected]>

HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part2.

57a17cb

github-actions bot added trunk Common labels Feb 4, 2025

fanshilun added 2 commits February 4, 2025 16:10

HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part2.

92afe16

HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part2.

08ff51a

github-actions bot added the build label Feb 4, 2025

HADOOP-19415. Fix CheckStyle.

f5f0159

slfan1989 marked this pull request as ready for review February 4, 2025 13:35

cnauroth requested changes Feb 4, 2025

View reviewed changes

HADOOP-19415. Fix CheckStyle.

cf57acb

HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part2.

6a873c9

cnauroth approved these changes Feb 5, 2025

View reviewed changes

slfan1989 merged commit b5cbca3 into apache:trunk Feb 5, 2025
4 checks passed

slfan1989 mentioned this pull request Feb 5, 2025

[DISCUSS] [JDK17] Upgrade JUnit / JavaDoc from 4 to 5. #7337

Draft

74 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part2. #7347

HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part2. #7347

Uh oh!

slfan1989 commented Feb 4, 2025 •

edited

Loading

Uh oh!

hadoop-yetus commented Feb 4, 2025

Uh oh!

slfan1989 commented Feb 4, 2025

Uh oh!

hadoop-yetus commented Feb 4, 2025

Uh oh!

hadoop-yetus commented Feb 4, 2025

Uh oh!

cnauroth left a comment

Uh oh!

slfan1989 commented Feb 5, 2025 •

edited

Loading

Uh oh!

hadoop-yetus commented Feb 5, 2025

Uh oh!

hadoop-yetus commented Feb 5, 2025

Uh oh!

cnauroth left a comment

Uh oh!

slfan1989 commented Feb 5, 2025

Uh oh!

Uh oh!

cnauroth commented Feb 5, 2025

Uh oh!

Uh oh!

HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part2. #7347

HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part2. #7347

Uh oh!

Conversation

slfan1989 commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Feb 4, 2025

Uh oh!

slfan1989 commented Feb 4, 2025

Uh oh!

hadoop-yetus commented Feb 4, 2025

Uh oh!

hadoop-yetus commented Feb 4, 2025

Uh oh!

cnauroth left a comment

Choose a reason for hiding this comment

Uh oh!

slfan1989 commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hadoop-yetus commented Feb 5, 2025

Uh oh!

hadoop-yetus commented Feb 5, 2025

Uh oh!

cnauroth left a comment

Choose a reason for hiding this comment

Uh oh!

slfan1989 commented Feb 5, 2025

Uh oh!

Uh oh!

cnauroth commented Feb 5, 2025

Uh oh!

Uh oh!

slfan1989 commented Feb 4, 2025 •

edited

Loading

slfan1989 commented Feb 5, 2025 •

edited

Loading