MAPREDUCE-7420. [JDK17] Upgrade Junit 4 to 5 in hadoop-mapreduce-client-core Part1. #7363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slfan1989
changed the title
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
slfan1989
force-pushed
the
MAPREDUCE-7420-v2
branch
from
e52bb39 to
615ae21
Compare
slfan1989
changed the title
|
🎊 +1 overall
This message was automatically generated. |
|
@cnauroth Could you please help review this PR? Thank you very much! |
cnauroth
reviewed
Feb 8, 2025
There was a problem hiding this comment.
@slfan1989 , I entered a few minor comments.
I am really blown away by how fast we are moving through these JUnit migrations thanks to the automated tooling. I can't imagine how long it would take for us to convert all of these tests manually. You should be really proud of this tool and look into open sourcing it more broadly!
| * @return a path implicitly unique amongst all methods in this class | ||
| * @throws IOException IO problems | ||
| */ | ||
| protected Path methodPath(String name) throws IOException { |
There was a problem hiding this comment.
I'm unclear, is anything actually calling this method?
There was a problem hiding this comment.
Thank you for your comment! I have removed the class in the latest code submission. Initially, I planned to add this method to hadoop-common to upgrade all unit tests in the hadoop-mapreduce-client-core module. However, I found that the test methods in other modules inherit from the test methods of the hadoop-mapreduce-client-core module, so I temporarily rolled back some changes. Unfortunately, I forgot to remove the class. I will complete the dependent test upgrades in mapreduce-client-core Part2.
| sc.getOutputPath()); | ||
| assertEquals( | ||
| HDFS_PATH | ||
| , sc.getOutputPath(), "Wrong output path from " + sc); |
slfan1989
force-pushed
the
MAPREDUCE-7420-v2
branch
from
ca8087d to
c16bcc2
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
@cnauroth Thank you very much for your help in reviewing the code! I believe the reason we were able to complete the unit test upgrades so quickly is not only due to the help of the tools, but also because of your proactive code reviews. I would also like to specially thank my colleague @zhtttylz, who completed most of the development of the tool. It has truly been a helpful tool, and after we finish upgrading the Hadoop unit tests, we plan to add it to Hadoop-Tools and provide documentation. This way, if there is any future work, such as upgrading from JUnit 5 to JUnit 6, we can handle it much more easily. |
@cnauroth and @slfan1989, thank you both for your guidance and support throughout the JUnit migration. Your thorough reviews and insights truly helped us move forward efficiently, and I’m grateful for your expertise. I also appreciate your feedback on the tool: although it still needs some refinement, I’m glad it helped accelerate our work. We plan to provide a final version once the Hadoop upgrade is complete, and I look forward to continuing our efforts together. Thank you again! |
|
🎊 +1 overall
This message was automatically generated. |
|
@cnauroth Can you help review this PR? Thank you very much! |
|
🎊 +1 overall
This message was automatically generated. |
74 tasks
|
@cnauroth Could you review this PR again? Thank you very much! |
cnauroth
approved these changes
Feb 10, 2025
|
🎊 +1 overall
This message was automatically generated. |
@cnauroth Thank you very much for helping review the code! I will merge this PR into the trunk branch. |
YanivKunda
pushed a commit
to YanivKunda/hadoop
that referenced
this pull request
Mar 23, 2025
…nt-core Part1. (apache#7363) Co-authored-by: Chris Nauroth <[email protected]> Reviewed-by: Chris Nauroth <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: MAPREDUCE-7420. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-core.
How was this patch tested?
Junit Test &
mvn clean test.For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?