Skip to content

HTTPCLIENT-2393 - remove rspauth from Authorization #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arturobernalg merged 1 commit into from
Sep 14, 2025
Merged

HTTPCLIENT-2393 - remove rspauth from Authorization #716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/DigestScheme.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,6 @@ private String createDigestResponse(final HttpRequest request) throws Authentica
params.add(new BasicNameValuePair("qop", qop == QualityOfProtection.AUTH_INT ? "auth-int" : "auth"));
params.add(new BasicNameValuePair("nc", nc));
params.add(new BasicNameValuePair("cnonce", cnonce));
params.add(new BasicNameValuePair("rspauth", hasha2));
}
if (algorithm != null) {
params.add(new BasicNameValuePair("algorithm", algorithm));
Expand Down
5 changes: 3 additions & 2 deletions httpclient5/src/test/java/org/apache/hc/client5/http/impl/auth/TestDigestScheme.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,7 +903,7 @@ void testDigestAuthenticationWithNonAsciiUsername() throws Exception {
}

@Test
void testRspAuthFieldAndQuoting() throws Exception {
void testRspAuthFieldNotPresentClient() throws Exception {
final ClassicHttpRequest request = new BasicClassicHttpRequest("POST", "/");
final HttpHost host = new HttpHost("somehost", 80);
final CredentialsProvider credentialsProvider = CredentialsProviderBuilder.create()
Expand All @@ -921,7 +921,8 @@ void testRspAuthFieldAndQuoting() throws Exception {

final Map<String, String> table = parseAuthResponse(authResponse);

Assertions.assertNotNull(table.get("rspauth"));
Assertions.assertNotNull(table);
Assertions.assertNull(table.get("rspauth"));
}

@Test
Expand Down
Loading