Skip to content

Make validation_history private before release #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2025
Merged

Make validation_history private before release #2054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyiceberg/table/update/validate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
VALIDATE_DATA_FILES_EXIST_OPERATIONS = {Operation.OVERWRITE, Operation.REPLACE, Operation.DELETE}


def validation_history(
def _validation_history(
table: Table,
from_snapshot: Snapshot,
to_snapshot: Snapshot,
Expand Down Expand Up @@ -100,7 +100,7 @@ def _deleted_data_files(
if parent_snapshot is None:
return

manifests, snapshot_ids = validation_history(
manifests, snapshot_ids = _validation_history(
table,
parent_snapshot,
starting_snapshot,
Expand Down
8 changes: 4 additions & 4 deletions tests/table/test_validate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
from pyiceberg.manifest import ManifestContent, ManifestEntry, ManifestEntryStatus, ManifestFile
from pyiceberg.table import Table
from pyiceberg.table.snapshots import Operation, Snapshot, Summary
from pyiceberg.table.update.validate import _deleted_data_files, _validate_deleted_data_files, validation_history
from pyiceberg.table.update.validate import _deleted_data_files, _validate_deleted_data_files, _validation_history


@pytest.fixture
Expand Down Expand Up @@ -69,7 +69,7 @@ def mock_read_manifest_side_effect(self: Snapshot, io: FileIO) -> list[ManifestF
return []

with patch("pyiceberg.table.snapshots.Snapshot.manifests", new=mock_read_manifest_side_effect):
manifests, snapshots = validation_history(
manifests, snapshots = _validation_history(
table,
oldest_snapshot,
newest_snapshot,
Expand Down Expand Up @@ -99,7 +99,7 @@ def test_validation_history_fails_on_snapshot_with_no_summary(
)
with patch("pyiceberg.table.update.validate.ancestors_between", return_value=[snapshot_with_no_summary]):
with pytest.raises(ValidationException):
validation_history(
_validation_history(
table,
oldest_snapshot,
newest_snapshot,
Expand Down Expand Up @@ -129,7 +129,7 @@ def mock_read_manifest_side_effect(self: Snapshot, io: FileIO) -> list[ManifestF
with patch("pyiceberg.table.snapshots.Snapshot.manifests", new=mock_read_manifest_side_effect):
with patch("pyiceberg.table.update.validate.ancestors_between", return_value=missing_oldest_snapshot):
with pytest.raises(ValidationException):
validation_history(
_validation_history(
table,
oldest_snapshot,
newest_snapshot,
Expand Down