Skip to content

feat: support pagination in list_* methods in rest catalog #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jayceslesar
Copy link
Contributor

@jayceslesar jayceslesar commented Jun 14, 2025

Closes #2084

Rationale for this change

Support pagination!

I looked at the rust iceberg implementation and noticed there is no laziness there either so seems fine for the non-lazy list methods to just exhaust into a list.

Also needed to move all requests behind a self._request_with_retries method that now handles all previous retry logic

Are these changes tested?

Added tests

Are there any user-facing changes?

Sort of. Existing compatability is not broken but there are new methods to lazily use the list_* methods.

@jayceslesar
Copy link
Contributor Author

Current CI failures look like they should be fixed in a different commit

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayceslesar
Copy link
Contributor Author

jayceslesar commented Jun 14, 2025

@kevinjqliu wdyt about a list_*_raw() method instead of supporting page size in the list_*_lazy() and list_*() that provides no abstraction to the user? I think that gives users the most control

@jayceslesar
Copy link
Contributor Author

lmk what you think this needs, imo if a user really needs to be able to make single requests they can write the thin layer to do that but if we want to provide the most basic level of call against the list API's I am happy to implement.

@jayceslesar
Copy link
Contributor Author

@kevinjqliu im gonna take another stab at this to see if we can accomplish with less changes

@jayceslesar
Copy link
Contributor Author

closing in favor of #2158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rest catalog does not support pagination
2 participants