Skip to content

maint: catalog implementation roundtripping tests #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jayceslesar
Copy link
Contributor

@jayceslesar jayceslesar commented Jun 14, 2025

In pursuit of #813

@jayceslesar
Copy link
Contributor Author

@kevinjqliu @Fokko thoughts here? I think would be pretty light work to set up a common test suite for all catalogs

Some immediate open questions:

  1. Hive and Rest are like a pure mock, but I think they can be worked in (open to ideas)
  2. What's up with this? https://github.com/apache/iceberg-python/blob/main/pyiceberg/catalog/sql.py#L100 NAMESPACE_MINIMAL_PROPERTIES Are those used anywhere?

@Fokko
Copy link
Contributor

Fokko commented Jun 14, 2025

Good call @jayceslesar 🙌

Hive and Rest are like a pure mock, but I think they can be worked in (open to ideas)

I'm not sure if I understand the question correctly, but let me give it a try. I'd prefer to avoid mock and rely on the integration tests that we have with the rest and hive image. The rest container is updated daily from the Java repository, and will let us know if something incompatible changes.

@jayceslesar
Copy link
Contributor Author

I'm not sure if I understand the question correctly, but let me give it a try. I'd prefer to avoid mock and rely on the integration tests that we have with the rest and hive image. The rest container is updated daily from the Java repository, and will let us know if something incompatible changes.

Amazing -- I will take a stab at consolidating the testing of all main catalog behavior in an integration test

@jayceslesar
Copy link
Contributor Author

jayceslesar commented Jun 15, 2025

Ok check out the latest commit. All integration tests. Looks like unable to run locally because im missing AWS_TEST_BUCKET... Possible to use minio for that?

Edit: Also the aws creds but I trust that this is all configured in CI and I just can't see it which is fine, so if we are happy with the little setup I have I can expand it to cover all common behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants