update daft links #2169
Open
update daft links #2169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Jul 4, 2025
There was a problem hiding this comment.
Thanks for fixing this @ccmao1130, we can move this forward as soon as the CI is green 👍
| @@ -78,7 +78,7 @@ gcsfs = { version = ">=2023.1.0", optional = true } | |||
| huggingface-hub = { version = ">=0.24.0", optional = true } | |||
| psycopg2-binary = { version = ">=2.9.6", optional = true } | |||
| sqlalchemy = { version = "^2.0.18", optional = true } | |||
| getdaft = { version = ">=0.2.12", optional = true } | |||
| daft = { version = ">=0.5.0", optional = true } | |||
There was a problem hiding this comment.
Updating the minor version requires running poetry lock. What's the rationale for bumping to 0.5.0?
There was a problem hiding this comment.
We changed our package from getdaft to daft and the earliest version for daft starts at v0.4.7 but we wanted to bump to v0.5.0
|
@ccmao1130 could you run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We recently changed our site domain so want to update all Daft documentation links. And noticed that our package should be updated from
getdafttodaftAre these changes tested?
yes
Are there any user-facing changes?
no