Skip to content

Improve Docs for IRC Catalog Connection #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

james5418
Copy link
Contributor

@james5418 james5418 commented Jul 6, 2025

Rationale for this change

Closes #2096
Included examples and detailed configuration guidance to enhance clarity.

Are these changes tested?

Are there any user-facing changes?

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Much needed. I added a few comments. Please take a look

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @james5418. I think we're almost there! Lets group the OAuth options together and split out SigV4 as a separate AWS specific auth option

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! LGTM!
Screenshot 2025-07-08 at 7 41 20 AM
Screenshot 2025-07-08 at 7 41 39 AM

@kevinjqliu kevinjqliu merged commit e33cf5a into apache:main Jul 8, 2025
3 checks passed
@kevinjqliu
Copy link
Contributor

Thanks for the contribution @james5418 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] docs for IRC catalog connection
2 participants