-
Notifications
You must be signed in to change notification settings - Fork 323
Improve Docs for IRC Catalog Connection #2175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Docs for IRC Catalog Connection #2175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! Much needed. I added a few comments. Please take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @james5418. I think we're almost there! Lets group the OAuth options together and split out SigV4 as a separate AWS specific auth option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @james5418 :) |
Rationale for this change
Closes #2096
Included examples and detailed configuration guidance to enhance clarity.
Are these changes tested?
Are there any user-facing changes?