Remove cached properties before updating table scans

[smaheshwar-pltr]

Rationale for this change

Closes #2179.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes, the scenario shown in the test and described in the issue now works.

[smaheshwar-pltr]

Note that normal methods annotated with property (not cached_property) aren't stored in dict.

[smaheshwar-pltr]

I don't think this is the nicest solution, though it feels like a minimally viable one

[jayceslesar]

you could add **kwargs in the TableScan constructor too right as a way to "fix"? I dont really think there is a good way to deal with this hahahaha

[smaheshwar-pltr]

you could add **kwargs in the TableScan constructor too right as a way to "fix"?

Yes, I think you're right.

I was a bit hesitant to change the constructor, and also technically subclasses of it would need to take **kwargs in their constructors too to avoid this issue themselves which feels easy to miss (though admittedly without #2031 we only have DataScan subclassing). But inspection doesn't feel nice either 🤔

[jayceslesar]

Maybe its fine to duplicate the update method in the subclasses and leave a comment about why its there for the cached properties?