Add close option #2390
Merged
Add close option #2390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fokko @kevinjqliu any chance we have this in the upcoming rc, if we consider it as a bug fix :) |
|
@kris-gaudel Thanks for picking this up 🙌 I would consider this an improvement |
Fokko
approved these changes
Aug 27, 2025
|
Thanks @kris-gaudel and @djouallah 🙌 |
10 tasks
kevinjqliu
pushed a commit
that referenced
this pull request
Aug 29, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
Part of #2399
# Rationale for this change
This PR introducs the implementation of `close()` method to the
`RestCatalog`.
And add corresponding test case which following the test pattern in
#2390
## Are these changes tested?
Yes
## Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2346
Rationale for this change
Add option to close catalog
Are these changes tested?
Yes
Are there any user-facing changes?
Yes