feat(transaction): Support snapshot validation #1353
Conversation
|
I'll tkae a look later today! |
| base: &Table, | ||
| to_snapshot: &SnapshotRef, | ||
| from_snapshot: Option<&SnapshotRef>, |
There was a problem hiding this comment.
I think should swap to and from here, @sungwy cleaned up my original implementation via https://github.com/apache/iceberg-python/pull/1959/files
| fn ancestors_between( | ||
| to_snapshot: &SnapshotRef, | ||
| from_snapshot: Option<&SnapshotRef>, |
There was a problem hiding this comment.
Should this live somewhere else? idrk but it does in the python impl
Also the to and from are swapped
Also might be more readable to refactor out the ancestors_of logic like we have in python
There was a problem hiding this comment.
Yes, I believe the validation should be a part of snapshot producing that happens when committing certain transaction actions.
This work has been paused and we are trying to make iceberg-rust able to write data first: #1382
I'll certain check out pyiceberg when resuming this!
Which issue does this PR close?
What changes are included in this PR?
SnapshotValidatorto hold these logicAre these changes tested?