Skip to content

fix(ci): fix comfy table problem when building WASM targets#3107

Merged
hubcio merged 1 commit into
apache:masterfrom
tungtose:fix-ci-bench
Apr 13, 2026
Merged

fix(ci): fix comfy table problem when building WASM targets#3107
hubcio merged 1 commit into
apache:masterfrom
tungtose:fix-ci-bench

Conversation

@tungtose

@tungtose tungtose commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Reason:

The default features of the comfy-table crates default-features use tty feature, pulling crossterm crate, which doesn't support WASM target

After fix:

  • Able to build WASM target:
image image

@codecov

codecov Bot commented Apr 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.75%. Comparing base (fcc5a44) to head (8cee0bb).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3107      +/-   ##
============================================
+ Coverage     72.74%   72.75%   +0.01%     
  Complexity      943      943              
============================================
  Files          1117     1117              
  Lines         96342    96342              
  Branches      73543    73559      +16     
============================================
+ Hits          70083    70093      +10     
+ Misses        23715    23685      -30     
- Partials       2544     2564      +20     
Components Coverage Δ
Rust Core 73.52% <ø> (+0.02%) ⬆️
Java SDK 62.30% <ø> (ø)
C# SDK 69.11% <ø> (-0.29%) ⬇️
Python SDK 81.43% <ø> (ø)
Node SDK 91.53% <ø> (+0.12%) ⬆️
Go SDK 38.97% <ø> (ø)
see 24 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hubcio hubcio changed the title fix(ci): failed to trunk build fix(ci): fix comfy table problem when building WASM targets Apr 13, 2026
@hubcio hubcio merged commit afd328f into apache:master Apr 13, 2026
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants