-
Notifications
You must be signed in to change notification settings - Fork 605
fix(github_graphql): Update Extract Jobs task to use Check Run instea… #8384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM, did you test it? |
I tested the change locally and was able to correctly get the check runs into the cicd_tasks domain table:
|
klesh
approved these changes
Apr 21, 2025
Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/plugins
This issue or PR relates to plugins
pr-type/bug-fix
This PR fixes a bug
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d of Check Suite
pr-type/bug-fix
,pr-type/feature-development
, etc.Summary
What does this PR do?
Refactors CheckRun into separate struct for use in Extract Jobs task.
Uses CheckRun to marshal raw collected jobs instead of CheckSuite
Does this close any open issues?
Closes #8383
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.