[INLONG-11861][CI] Compile dataproxy-sdk fail when there is no .git dictionary in the base path #11862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ictionary in the base path
added 3 commits
May 13, 2025 09:27
…ictionary in the base path
…ictionary in the base path
…ictionary in the base path
vernedeng
approved these changes
May 13, 2025
fuweng11
approved these changes
May 13, 2025
featzhang
reviewed
May 13, 2025
| try (InputStream is = ProxyUtils.class.getResourceAsStream("/git.properties")) { | ||
| properties.load(is); | ||
| sdkVersion = properties.getProperty("git.build.version"); | ||
| try (InputStream is = ProxyUtils.class.getClassLoader().getResourceAsStream("sdk.version")) { |
Member
There was a problem hiding this comment.
src/main/resources
false
src/main/resources-filtered
true
https://maven.apache.org/plugins/maven-resources-plugin/examples/filter.html
Using Maven resource filtering seems to be a good solution, which does not rely on git.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11861
Adjust the SDK version acquisition method