Support dataset module for iotdb in ainode #15686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRZbulabula
requested changes
Jun 10, 2025
| return AINodeDescriptor().get_config().get_ain_data_storage_cache_size() != 0 | ||
|
|
||
|
|
||
| class IoTDBTreeModelDataset(BasicDatabaseForecastDataset): |
There was a problem hiding this comment.
It is cratical to explain how ur classes will interact with the caller. Plz add some annotations to the provided interfaces of these classes. BTW, the name iotdb.py seems conflict with our main project, I think the iotdb_dataset.py is better.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15686 +/- ##
============================================
- Coverage 39.17% 39.14% -0.04%
Complexity 198 198
============================================
Files 4835 4835
Lines 314122 314125 +3
Branches 39398 39393 -5
============================================
- Hits 123066 122966 -100
- Misses 191056 191159 +103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's just a demo function require more optimaztion/