-
Notifications
You must be signed in to change notification settings - Fork 14.4k
MINOR: upgrade pip from 20.2.2 to 21.1.1 #10661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This is failing for me with:
@chia7712 are you using a different jdk base docker image version on your m1? |
IIRC, I was using |
build image on MacBook Air M1build image on iMac 27 intel@lbradstreet Please take a look at above screenshot. I don't observe the error you mentioned. BTW, the step |
@chia7712 thanks for checking. Yes, my dockerfile was a bit modified. The unmodified run is:
|
@lbradstreet Could you share the ID of |
I ran docker system prune before reporting this in case something was happening there.
|
Maybe I didn't fully clear all images. I'll see if I can delete them in another way. |
@chia7712 sorry for the false alarm and thanks for checking that it worked on your side. The problem was that I should have run |
Hmm, I also hit that same error today. It seems to have been caused because the image was running Debian 9, and the latest version of After running
Building on the recent discussion here, maybe what's happening is that we had an older cached version of the openjdk:8 image, which limited the python version to 3.5, which in turn make it impossible to upgrade to pip 21. Just wanted to provide more context. I assume others will hit the same thing. The solution is to run |
Ah, and now I noticed that we've added a message to this effect in the script today: #10995 Carry on :) |
The following error happens on my mac m1 when building docker image for system tests.
There was a related issue: pypa/pip#9689 and it is already fixed by pypa/pip#9689 (included by pip 21.1.1). I test the pip 21.1.1 and it works well on mac m1.
Committer Checklist (excluded from commit message)