KAFKA-19666: Remove old restoration codepath from PauseResumeIntegrationTest [2/N] #20463
+27
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
There was a problem hiding this comment.
Pull Request Overview
Cleans up the PauseResumeIntegrationTest by removing state updater parameterization and simplifying test methods to run with default configuration only.
- Converted parameterized tests to regular tests by removing
@ParameterizedTestand@ValueSourceannotations - Removed state updater configuration parameter from props() method and all test methods
- Updated method calls to use simplified signatures without state updater boolean parameter
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Hey @shashankhs11 . Could you name your PRs: KAFKA-19666: {descriptive naming} [k/N] -- so that we understand which is which? This one, for example, I'll name KAFKA-19666: Remove old restoration codepath from PauseResumeIntegrationTest [2/N] |
lucasbru
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up
PauseResumeIntegrationTestReviewers: Lucas Brutschy [email protected]