KAFKA-15983 Kafka-acls should return authorization already done if repeating work is issued #20482
+41
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Sep 4, 2025
Thanks for the review. The test was added. |
chia7712
reviewed
Sep 6, 2025
There was a problem hiding this comment.
@jack2012aa thanks for this patch. Two small comments remains. PTAL
| } | ||
|
|
||
| if (!aclBindings.isEmpty()) { | ||
| System.out.println("Adding ACLs for resource `" + resource + "`: " + NL + " " + aclsToAdd.stream().map(a -> "\t" + a).collect(Collectors.joining(NL)) + NL); |
There was a problem hiding this comment.
aclsToAdd.stream() could be replaced by aclBindings.stream().map(AclBinding::entry), right?
| admin.createAcls(aclBindings).all().get(); | ||
|
|
||
| AclBindingFilter filter = new AclBindingFilter(resource.toFilter(), AccessControlEntryFilter.ANY); | ||
| Collection<AclBinding> existingBindings = admin.describeAcls(filter).values().get(); |
There was a problem hiding this comment.
var existingBindingsSet = Set.copyOf(admin.describeAcls(filter).values().get());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
kafka-acls.shdoesn't print message about duplicate authorization.Changes
Now the cli searches for existing AclBinding, prints duplicate bindings, and removes them from the adding list.