Skip to content

KNOX-3158: Enhancing the maintainability of knox-shell #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Raghav-Mah3shwari
Copy link
Contributor

Increasing the maintainability of the code by reducing code smells from gateway-shell

How was this patch tested?

The changes were made in local first then a maven build was triggered. The build was successful

@lmccay
Copy link
Contributor

lmccay commented Jun 12, 2025

@Raghav-Mah3shwari - please show that you have tested the shell functionality related to the changes that you have made. We need to know that there has been some manual testing for the shell work since much of that is hard to unit test. Some example output exercising the the affected code paths would be a good way to do this.

@Raghav-Mah3shwari
Copy link
Contributor Author

Hi @lmccay can you give me some suggestions on how to test it and verify it. Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants